Stardew Valley

Fish — Location — Season:

Albacore — Ocean — Fall, Winter
Anchovy — Ocean — Spring, Fall
Bream — River — All Seasons
Bullhead — Lake — All Seasons
Carp — Lake, Forest Pond, Sewers, Secret Woods — All Seasons
Catfish — River, Forest Pond — Rain
Chub — River, Lake — All Seasons
Dorado — River — Summer
Eel — Ocean — Spring, Fall, Rain
Ghostfish — Mines — All Seasons
Halibut — Ocean — Spring, Summer, Winter
Herring — Ocean — Spring, Winter
Ice Pip — Mine — All Seasons
Largemouth Bass — Lake — All Seasons
Lava Eel — Mine — All Seasons
Lingcod — Lake, River — Winter
Octopus — Ocean — Summer
Perch — Lake, River — Winter
Pike— Lake, River — Summer, Winter
Pufferfish — Ocean — Summer
Rainbow Trout — River, Mountain — Summer
Red Mullet — Ocean — Summer, Winter
Red Snapper — Ocean — Summer, Fall
Salmon — River — Fall
Sandfish — Desert — All Seasons
Sardine — Ocean — Spring, Fall, Winter
Scorpion Carp — Desert — All Seasons
Sea Cucumber — Ocean — Fall, Winter
Shad — River — Spring, Summer, Fall
Smallmouth Bass — River, Lake — Spring, Fall
Squid — Ocean — Winter
Stonefish — Mine — All Seasons
Sturgeon — Lake — Summer, Winter
Sunfish — River — Spring, Summer
Super Cucumber — Ocean — Summer, Fall, Winter
Tiger Trout — River, Lake — Fall, Winter
Tilapia — Ocean — Summer, Fall
Tuna — Ocean — Summer, Winter
Walleye — River, Lake, Forest Pond — Fall, Rain
Woodskip — Forest Pond — All Seasons

Legendary Fish — Location — Season:
Angler — North of Joja — Fall
Crimsonfish — Ocean near East Pier — Summer
Glacierfish — South of Arrowhead Island — Winter
Legend — Mine Lake — Spring, Rain
Mutant Carp — Sewers — All Seasons

There are two more fish not mention in either of the guides above that are needed for this achievement.

The Void Salmon and the Slimejack are two fish that are obtain in a questline that becomes available after the completion of the Community Center/Joja Warehouse. To initiate the quest head to the railroad after the completion of the Com Center and the wizard will give you the quest.

The first location you need to go to is sewers where you'll talk to Krobus in order to gain access to the Mutant Bug Lair, which is where you'll get the Dark Talisman, but more importantly, you'll be able to catch the Slimejack.

Take the Dark Talisman back to the Railroad and place it in the artifact blocking the cave in the back of the area. This will allow access to the Witch's Swamp where you can complete another quest, but also catch the Void Salmon.

These fish and areas were added in a update the PC version of the game and therefore were not required for the original achievement. However since they were in the Xbox version from the beginning, they are required. You can checked which fish you have caught by going to the collections tab in the menu. Here you will see the Void Salmon and Slimejack are the last two greyed-out fish in list. I can confirm you need these fish as I have caught ever other fish besides these two and the achievement did not unlock.

Wiki page: http://stardewvalleywiki.com/Witch%27s_Swamp